Infrastructure: Run Prettier on commit of all files #2614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfxpnk
reviewed
Feb 13, 2023
howard-e
approved these changes
Feb 14, 2023
Contributor
|
This made me notice there are some outdated paths in the |
mcking65
added
the
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all the linting relies on prettier, the commit hook can now run on all filetypes.
Ran
npx prettier -w .and ignored some filetypes like HTML and 3rd party code.This doesn't add any specific CI to double check for regressions though for those that don't commit with the Husky hooks enabled