-
Notifications
You must be signed in to change notification settings - Fork 28
Define interaction between platform credential chooser and the user agent #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small language fix
|
@mohamedamir added the diagram above, as we discussed... will fix it up and add to the spec. |
2a0cafb to
e5beeef
Compare
Great! |
e5beeef to
d85da59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't agree with having this in the spec, as it is very UA specific.
It it also essentially mandates that the credential selector is a UA component, which is not always the case (in most cases it is not).
This is why I previously had the DC Client and DC Client Platform definitions which can clearly separate some of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweaks for consistency within source, thence to consistency in rendering for humans.
|
Discussed on the FedID WG DC API Series B call |
Sorry, that is not the intent. It's not a UA component, it's either a platform component or generated by the OS.
We can just clarify that in the text. |
To be clear, these are not UA specific things - they are generic things to any user agent:
So there's nothing in the above that is "UA specific", both WebKit and Chromium need to do the same things here (and hopefully Gecko too 🧡🦊). Why this model is needed. |
Co-authored-by: Mohamed Amir Yosef <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Mohamed Amir Yosef <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @marcoscaceres !
I think it's in good shape except some minor comments
@timcappalli could you please take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some terminology issues, but I don't think they affect implementation. We can fix them once #387 gets merged.
I also don't think this should be it's own section, but that can also get changed at a later date.
Co-authored-by: Tim Cappalli <[email protected]> Co-authored-by: Mohamed Amir Yosef <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Closes #305
Closes #112
This pull request adds a new section to the
index.htmlfile that defines and describes the "Credential Request Coordinator" concept, which is central to managing digital credential interactions within a user agent. The section introduces the coordinator's responsibilities, lifecycle management, and its interaction states, laying the groundwork for future implementation details.New "Credential Request Coordinator" section:
credential request coordinator, explaining its role as a user-agent-defined component that mediates digital credential interactions within a top-level traversable, orchestrates presentation/issuance flows, and manages interaction states.idle,requesting,aborting) used by the coordinator to manage the lifecycle of credential requests.Preview | Diff