T8031: file comparison in boolean check unsaved_commits should ignore blank lines

[jestabro]

Change summary

Discrepancies in blank lines, whitespace, or missing final newline can lead to false positives in the boolean check unsaved_commits, which is used to provide warning messages on reboot/poweroff and commit-confirm.

The discrepancies can arise due to automated formatting at boot from migration/activation scripts or intialization on first install; such discrepancies trigger a false positive due to the use of Python's filecmp module.

Irrespective of consistent formatting, use a smarter file comparison utility.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[c-po]

strip() whitespaces before comparing the running configuration with the saved configuration.

[github-actions]

CI integration 👍 passed!

Details

CI logs

• CLI Smoketests (no interfaces) 👍 passed
• CLI Smoketests VPP 👍 passed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• Config tests VPP 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed