-
Notifications
You must be signed in to change notification settings - Fork 395
ssh: T7483: Add fido2 PubkeyAuthOptions #4852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
|
👍 |
90e587d to
eef18e3
Compare
dmbaturin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is certainly a useful addition. I'm not a big fan of the name verify-required and might prefer that syntax to be require <verification|touch>.
The current syntax mirrors OpenSSH options from https://man.openbsd.org/sshd_config#PubkeyAuthOptions that might be familiar to OpenSSH users. This is a purely aesthetic considerations and I don't consider it a blocker for merging this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @scj643,
thanks for the contribution - as @dmbaturin already outline the CLI could be improved. Let me throw in another idea:
set service ssh fido pin-required
set service ssh fido touch-required
That sounds great. I'll change that later today. |
|
Changes made and updated the documentation. |
|
The documentation could use an example on how to set this up and get it working. Please also extend the SSH Smoketests to verify the CLI nodes actually males it into the sshd_config |
|
CI integration 👍 passed! Details
|
Change summary
Add
PubkeyAuthOptionsto allow requiring touch and user verification.Types of changes
Related PRs
Related Task(s)
https://vyos.dev/T7483
How to test / Smoketest result
Run ssh with these options enabled and verify that it requires touch and pin verification.
Checklist: