Skip to content

Conversation

@vibhash-singh
Copy link
Contributor

Description

Don't add empty values in Combobox.

Motivation and Context

Fixes #13274

How Has This Been Tested?

Unit testing and Visually

Markup:

<template>
  <div id="app">
    <v-app id="inspire">
      <v-container fluid>
        <v-combobox
          v-model="model"
          :items="items"
          :search-input.sync="search"
          hide-selected
          hint="Maximum of 5 tags"
          label="Add some tags"
          multiple
          persistent-hint
          small-chips
        >
        </v-combobox>
      </v-container>
    </v-app>
  </div>
</template>

<script>
export default {
   data: () => ({
    items: ['Gaming', 'Programming', 'Vue', 'Vuetify'],
    model: ['Vuetify'],
    search: null,
  })
}
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added this to the v2.4.x milestone Mar 23, 2021
@johnleider johnleider added C: VCombobox T: bug Functionality that does not work as intended/expected labels Mar 23, 2021
@KaelWD KaelWD changed the title fix(VCombobox): don't add empty values to combobox fix(VCombobox): don't add empty values Mar 23, 2021
@KaelWD KaelWD merged commit d2a042b into vuetifyjs:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: VCombobox T: bug Functionality that does not work as intended/expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] Empty chip when emptying text field

3 participants