Skip to content

Conversation

@Mdev303
Copy link

@Mdev303 Mdev303 commented Aug 1, 2020

Add checkboxesColor Prop

Description

Create a checkboxesColor prop in VDataTable.ts and header.ts (the value is passed from vdatatable to header)

resolves #8348

Motivation and Context

Add a easy way to change the color of checkboxes color
#8348

How Has This Been Tested?

visually

Markup:

<template>
  <v-container>
    <v-data-table
      :headers="headers"
      :items="desserts"
      :items-per-page="5"
      checkboxesColor="red"
      class="elevation-1"
      item-key="name"
      show-select
    ></v-data-table>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
      headers: [
        {
          text: 'Dessert (100g serving)',
          align: 'start',
          sortable: false,
          value: 'name',
        },
        { text: 'Calories', value: 'calories' },
        { text: 'Fat (g)', value: 'fat' },
        { text: 'Carbs (g)', value: 'carbs' },
        { text: 'Protein (g)', value: 'protein' },
        { text: 'Iron (%)', value: 'iron' },
      ],
      desserts: [
        {
          name: 'Frozen Yogurt',
          calories: 159,
          fat: 6.0,
          carbs: 24,
          protein: 4.0,
          iron: '1%',
        },
        {
          name: 'Ice cream sandwich',
          calories: 237,
          fat: 9.0,
          carbs: 37,
          protein: 4.3,
          iron: '1%',
        },
        {
          name: 'Eclair',
          calories: 262,
          fat: 16.0,
          carbs: 23,
          protein: 6.0,
          iron: '7%',
        },
        {
          name: 'Cupcake',
          calories: 305,
          fat: 3.7,
          carbs: 67,
          protein: 4.3,
          iron: '8%',
        },
        {
          name: 'Gingerbread',
          calories: 356,
          fat: 16.0,
          carbs: 49,
          protein: 3.9,
          iron: '16%',
        },
        {
          name: 'Jelly bean',
          calories: 375,
          fat: 0.0,
          carbs: 94,
          protein: 0.0,
          iron: '0%',
        },
        {
          name: 'Lollipop',
          calories: 392,
          fat: 0.2,
          carbs: 98,
          protein: 0,
          iron: '2%',
        },
        {
          name: 'Honeycomb',
          calories: 408,
          fat: 3.2,
          carbs: 87,
          protein: 6.5,
          iron: '45%',
        },
        {
          name: 'Donut',
          calories: 452,
          fat: 25.0,
          carbs: 51,
          protein: 4.9,
          iron: '22%',
        },
        {
          name: 'KitKat',
          calories: 518,
          fat: 26.0,
          carbs: 65,
          protein: 7,
          iron: '6%',
        },
      ],
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • [x ] The PR title is no longer than 64 characters.
  • [x ] The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • [ x] My code follows the code style of this project.
  • [ x] I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@MajesticPotatoe MajesticPotatoe added this to the v2.5.0 milestone Dec 31, 2020
@johnleider johnleider requested review from KaelWD and nekosaur and removed request for KaelWD and nekosaur March 26, 2021 03:18
@nekosaur
Copy link
Member

Personal preference perhaps but I think checkboxColor sounds better than checkboxesColor

@Mdev303
Copy link
Author

Mdev303 commented Mar 27, 2021

I agree, but i think we can change that when we will refactor this component for vuetify 3

@nekosaur
Copy link
Member

There's no reason to add a new prop in 2.5 and then immediately making a breaking change in 3.0

@Mdev303
Copy link
Author

Mdev303 commented Mar 28, 2021

name changed 👌

@Mdev303 Mdev303 changed the title feat(VDataTable): Add checkboxesColor prop feat(VDataTable): Add checkboxColor prop Mar 28, 2021
@KaelWD KaelWD merged commit 4c469fd into vuetifyjs:dev Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants