Skip to content
This repository was archived by the owner on May 8, 2025. It is now read-only.

feat: icon/language choice, customProperties, update vuetify to 1.2 #28

Merged
merged 29 commits into from
Aug 28, 2018
Merged

feat: icon/language choice, customProperties, update vuetify to 1.2 #28

merged 29 commits into from
Aug 28, 2018

Conversation

jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Aug 13, 2018 •
edited
Loading

  • allows chosing default font (md, mdi, fa5, fa4)
  • sets iconfont in vuetify options
  • sets proper icons (depending on icon font) in App.vue template
  • allows choosing between installing font (icon font and roboto) as a dependency or using it from cdn
  • sets customProperties in vuetify options
  • allows choosing locale
  • added vue.config.js
  • refactored code

TODO:

  • favicons-webpack-plugin?

@jacekkarczmarczyk jacekkarczmarczyk changed the title [WIP] feat: icon choice feat: icon choice, curtomProperties Aug 14, 2018
@jacekkarczmarczyk jacekkarczmarczyk added enhancement New feature or request and removed in progress labels Aug 14, 2018
@jacekkarczmarczyk jacekkarczmarczyk changed the title feat: icon choice, curtomProperties feat: icon choice, customProperties Aug 14, 2018
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Aug 14, 2018
@jacekkarczmarczyk jacekkarczmarczyk changed the title feat: icon choice, customProperties feat: icon choice, customProperties, update vuetify to 1.2 Aug 14, 2018
@jacekkarczmarczyk jacekkarczmarczyk added this to the 0.2.0 milestone Aug 14, 2018
@jacekkarczmarczyk jacekkarczmarczyk changed the title feat: icon choice, customProperties, update vuetify to 1.2 feat: icon/language choice, customProperties, update vuetify to 1.2 Aug 15, 2018
@jacekkarczmarczyk jacekkarczmarczyk mentioned this pull request Aug 15, 2018
Merged
9 tasks
KaelWD
KaelWD reviewed Aug 19, 2018
View reviewed changes
generator/tools/alaCarte.js Outdated
{
vuetify: {
transform: 'vuetify/es5/components/${member}',
transform: 'vuetify/es5/components/$' + '{member}',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

johnleider
johnleider previously requested changes Aug 25, 2018
View reviewed changes
prompts.js
{
name: 'useTheme',
type: 'confirm',
message: 'Use custom theme?',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should retain 644 permissions

prompts.js Outdated
}
}
]
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove trailing semi

@jacekkarczmarczyk jacekkarczmarczyk merged commit 4960ef4 into dev Aug 28, 2018
@jacekkarczmarczyk jacekkarczmarczyk deleted the feat/icon-choice branch August 28, 2018 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@KaelWD KaelWD KaelWD left review comments

@johnleider johnleider johnleider left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@jacekkarczmarczyk jacekkarczmarczyk

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jacekkarczmarczyk @johnleider @KaelWD