Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

Conversation

@billyyyyy3320
Copy link
Member

fix #13

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulivz ulivz merged commit 7d40fe3 into vuepress:master Aug 5, 2019
@ulivz
Copy link
Member

ulivz commented Aug 5, 2019

The better commit message would be:

fix: config for summary, summaryLength and pwa (close: #13)(#14)

Whatever that's a great pull request! 👍

@billyyyyy3320 billyyyyy3320 deleted the feat/fix_summary_config branch February 11, 2020 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't hide summary by setting option summary to false

2 participants