Skip to content

feat($config): Allow overriding badges colors (close #1940) #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2019
Merged

feat($config): Allow overriding badges colors (close #1940) #1941

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1ff37d
feat($config): Allow overriding badges colors (close #1940)
kefranabg Oct 12, 2019
761aaa5
fix: Rename stylus color variables
kefranabg Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/@vuepress/core/lib/client/style/config.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ $textColor = #2c3e50
$borderColor = #eaecef
$codeBgColor = #282c34
$arrowBgColor = #ccc
$badgeTip = #42b983
$badgeWarning = darken(#ffe564, 35%)
$badgeError = #DA5961
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with $accentColor, $textColor, etc. , adding "color" to variable name could be better.

For example: $badgeTipColor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


// layout
$navbarHeight = 3.6rem
Expand Down
6 changes: 3 additions & 3 deletions packages/@vuepress/theme-default/global-components/Badge.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ export default {
color white
background-color #42b983
&.tip, &.green
background-color #42b983
background-color $badgeTip
&.error
background-color #DA5961 //#f66
background-color $badgeError
&.warning, &.warn, &.yellow
background-color darken(#ffe564, 35%)
background-color $badgeWarning
& + &
margin-left 5px
</style>
3 changes: 3 additions & 0 deletions packages/docs/docs/config/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ $accentColor = #3eaf7c
$textColor = #2c3e50
$borderColor = #eaecef
$codeBgColor = #282c34
$badgeTip = #42b983
$badgeWarning = darken(#ffe564, 35%)
$badgeError = #DA5961
```

::: danger Note
Expand Down
3 changes: 3 additions & 0 deletions packages/docs/docs/zh/config/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@ $accentColor = #3eaf7c
$textColor = #2c3e50
$borderColor = #eaecef
$codeBgColor = #282c34
$badgeTip = #42b983
$badgeWarning = darken(#ffe564, 35%)
$badgeError = #DA5961
```

::: danger Note
Expand Down