Skip to content

fix: pause dep collection during immediate watcher invocation #11943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 30, 2021
Merged

fix: pause dep collection during immediate watcher invocation #11943

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b15a874
fix: pause dep collection during immediate watcher invocation (#11942)
delaneyb Mar 7, 2021
6434e7c
test: child immediate watcher Dep.target (#11943)
delaneyb Mar 8, 2021
f434182
chore: update child immediate watcher test case (#11943)
delaneyb Mar 9, 2021
52522ba
Update test/unit/features/instance/methods-lifecycle.spec.js
delaneyb Mar 10, 2021
18d3f63
Apply suggestions from code review
delaneyb Mar 10, 2021
ca5eb90
chore: apply suggestions from code review
delaneyb Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/core/instance/state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,11 +355,13 @@ export function stateMixin (Vue: Class<Component>) {
options.user = true
const watcher = new Watcher(vm, expOrFn, cb, options)
if (options.immediate) {
pushTarget()
try {
cb.call(vm, watcher.value)
} catch (error) {
handleError(error, vm, `callback for immediate watcher "${watcher.expression}"`)
}
popTarget()
}
return function unwatchFn () {
watcher.teardown()
Expand Down