chore: upgrade to ESLint v6 #11099
Closed
chore: upgrade to ESLint v6 #11099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
commented
Feb 11, 2020
| @@ -1,5 +1,4 @@ | |||
| /* @flow */ | |||
| /* globals MutationObserver */ | |||
There was a problem hiding this comment.
This is now included the in this env globals by default.
kaicataldo
commented
Feb 11, 2020
| ) | ||
| } | ||
| if (el.attrsMap.hasOwnProperty('v-for')) { | ||
| if (Object.prototype.hasOwnProperty.call(el.attrsMap, 'v-for')) { |
There was a problem hiding this comment.
This fixes errors from https://eslint.org/docs/rules/no-prototype-builtins.
kaicataldo
commented
Feb 11, 2020
| const style = stylesheet[name] | ||
| for (const key in style) { | ||
| if (!result.hasOwnProperty(key)) { | ||
| if (!Object.prototype.hasOwnProperty.call(result, key)) { |
There was a problem hiding this comment.
This fixes errors from https://eslint.org/docs/rules/no-prototype-builtins.
kaicataldo
commented
Feb 11, 2020
| Vue.set(vm.data, 'bar', 123) | ||
| expect(vm.data.bar).toBe(123) | ||
| expect(vm.data.hasOwnProperty('bar')).toBe(false) | ||
| expect(Object.prototype.hasOwnProperty.call(vm.data, 'bar')).toBe(false) |
There was a problem hiding this comment.
This fixes errors from https://eslint.org/docs/rules/no-prototype-builtins.
|
Anything else I can do here to help land this? :) |
|
One more friendly ping |
|
One last friendly ping. Happy to close this if this isn't something the core team would like to do right now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
I'm a maintainer of ESLint and am working on getting our regression build for ESLint updated to ESLint v6. I figured I could make a quick PR to get the Vue codebase updated. This is my first PR, so please let me know if I missed something!