Skip to content

feat: support lazy modifier with setValue #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2020
Merged

feat: support lazy modifier with setValue #1467

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f112aa7
feat: support lazy modifier with setValue
lmiller1990 Mar 12, 2020
90fb6c1
fix: check lazy modifier
lmiller1990 Mar 13, 2020
1b50e5e
fix: add check for vModifiers
lmiller1990 Mar 13, 2020
ad9c643
fix: include textarea in lazy check
lmiller1990 Mar 13, 2020
cc63536
fix: skip lazy modifier spec for Vue 2.0
lmiller1990 Mar 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/test-utils/src/wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,10 +569,24 @@ export default class Wrapper implements BaseWrapper {
tagName === 'TEXTAREA' ||
tagName === 'SELECT'
) {
const event = tagName === 'SELECT' ? 'change' : 'input'
// $FlowIgnore
this.element.value = value
this.trigger(event)

if (tagName === 'SELECT') {
this.trigger('change')
} else {
this.trigger('input')
}

// for v-model.lazy, we need to trigger a change event, too.
// $FlowIgnore
if (
tagName === 'INPUT' &&
this.element._vModifiers &&
this.element._vModifiers.lazy
) {
this.trigger('change')
}
} else {
throwError(`wrapper.setValue() cannot be called on this element`)
}
Expand Down
3 changes: 3 additions & 0 deletions test/resources/components/component-with-input.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
{{ textVal }}
{{ selectVal }}
{{ radioVal }}
<input id="lazy" type="text" v-model.lazy="lazy" />
{{ lazy }}
</div>
</template>

Expand All @@ -44,6 +46,7 @@ export default {
name: 'component-with-input',
data() {
return {
lazy: '',
checkboxVal: undefined,
textVal: undefined,
textareaVal: undefined,
Expand Down
9 changes: 9 additions & 0 deletions test/specs/wrapper/setValue.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@ describeWithShallowAndMount('setValue', mountingMethod => {
expect(wrapper.text()).to.contain('input text awesome binding')
})

it('updates dom with input v-model.lazy', async () => {
const wrapper = mountingMethod(ComponentWithInput)
const input = wrapper.find('input#lazy')
input.setValue('lazy')
await Vue.nextTick()

expect(wrapper.text()).to.contain('lazy')
})

it('sets element of select value', () => {
const wrapper = mountingMethod(ComponentWithInput)
const select = wrapper.find('select')
Expand Down