Skip to content

Improve performance by compressing in parallel ✈️ #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Improve performance by compressing in parallel ✈️ #7313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/@vue/cli/lib/Creator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,8 @@ module.exports = class Creator extends EventEmitter {
// run complete cbs if any (injected by generators)
log(`⚓ Running completion hooks...`)
this.emit('creation', { event: 'completion-hooks' })
for (const cb of afterInvokeCbs) {
await cb()
}
for (const cb of afterAnyInvokeCbs) {
await cb()
}
await Promise.all(afterInvokeCbs.map((cb) => cb()))
await Promise.all(afterAnyInvokeCbs.map((cb) => cb()))

if (!generator.files['README.md']) {
// generate README.md
Expand Down
4 changes: 1 addition & 3 deletions packages/@vue/cli/lib/Generator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,7 @@ module.exports = class Generator {
}
})

for (const postProcess of this.postProcessFilesCbs) {
await postProcess(files)
}
await Promise.all(this.postProcessFilesCbs.map((postProcess) => postProcess(files)))
debug('vue:cli-files')(this.files)
}

Expand Down
8 changes: 2 additions & 6 deletions packages/@vue/cli/lib/invoke.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,8 @@ async function runGenerator (context, plugin, pkg = getPkg(context)) {

if (afterInvokeCbs.length || afterAnyInvokeCbs.length) {
logWithSpinner('⚓', `Running completion hooks...`)
for (const cb of afterInvokeCbs) {
await cb()
}
for (const cb of afterAnyInvokeCbs) {
await cb()
}
await Promise.all(afterInvokeCbs.map((cb) => cb()))
await Promise.all(afterAnyInvokeCbs.map((cb) => cb()))
stopSpinner()
log()
}
Expand Down