Skip to content

feat: shallow mount #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 5, 2020
Merged

feat: shallow mount #107

merged 4 commits into from
May 5, 2020

Conversation

@dobromir-hristov
Copy link
Contributor

@dobromir-hristov dobromir-hristov commented May 4, 2020 •
edited by lmiller1990
Loading

Adds a basic implementation for shallowMount via MountOptions.shallow

I still need to add tests, but it seems to work great.

resolves #6

lmiller1990
lmiller1990 reviewed May 4, 2020
View reviewed changes
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy - mainly since you did all the hard work in stubs. Awesome!

Should we include a shallowMount function too, perhaps with a message "please use the shallow option. `shallowMount will be removed in a future release"? That might be useful for migration purposes.

shallow: true feels super clean to me! Not sure how others feel - happy to have a discussion around this if people feel strongly about a top level shallowMount method.

@lmiller1990
Copy link
Member

lmiller1990 commented May 4, 2020

I think we move to beta once this is merged and docs are up to date.

@lmiller1990 lmiller1990 self-requested a review May 5, 2020 07:05
lmiller1990
lmiller1990 approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything else we want to add or is this good to merge? Code seems fine!

@dobromir-hristov
Copy link
Contributor Author

dobromir-hristov commented May 5, 2020

I dont think so.. I dont know if there is a point to add more tests. It is just mount with stubs :P

@lmiller1990 lmiller1990 merged commit 4155bdd into master May 5, 2020
@lmiller1990 lmiller1990 deleted the feat/shallow-mount branch May 5, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

epic: shallow: true mounting option (previously shallowMount)

3 participants

@dobromir-hristov @lmiller1990