Fix: ignore preformatted tokens in html-indent
#659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I thought about fixing with few changes, but because I could not solve the problem of become invalid with other patterns, I solved it with logic of this PR. |
michalsnik
suggested changes
Nov 18, 2018
mysticatea
reviewed
Nov 18, 2018
Member
|
@mysticatea can you re-check pls? :) |
Member
|
I will take a look. Thank you for the ping. |
mysticatea
approved these changes
Nov 24, 2018
Member
mysticatea
left a comment
mysticatea
left a comment
There was a problem hiding this comment.
All concerns I had are resolved.
LGTM, thank you so much!
Member
|
Just I have found, |
Member
Author
|
Do I need to change the processing of |
Member
|
Probably, separated PR is better. |
Member
Author
|
@mysticatea Thank you for merged this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for fix the issue #653.
I stored tokens in the
<pre>element, and excluded those tokens from validation.--
Fixed #653
The cause of this issue was due to side effects of #503.