Skip to content

Fix false positives for script setup with ts literal type in vue/require-valid-default-prop #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2022
Merged

Fix false positives for script setup with ts literal type in vue/require-valid-default-prop #1854

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd69427
Fix false positives for script setup with ts literal type in `vue/req…
ota-meshi Apr 19, 2022
fd93e56
remove dupe test
ota-meshi Apr 19, 2022
29a0945
Add testcase
ota-meshi Apr 19, 2022
defa8ab
Update tests/lib/rules/require-valid-default-prop.js
ota-meshi Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions lib/utils/ts-ast-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,23 +260,21 @@ function inferRuntimeType(context, node, checked = new Set()) {
return ['Array']

case 'TSLiteralType':
switch (node.literal.type) {
//@ts-ignore ?
case 'StringLiteral':
return ['String']
//@ts-ignore ?
case 'BooleanLiteral':
return ['Boolean']
//@ts-ignore ?
case 'NumericLiteral':
//@ts-ignore ?
// eslint-disable-next-line no-fallthrough
case 'BigIntLiteral':
return ['Number']
default:
return [`null`]
if (node.literal.type === 'Literal') {
switch (typeof node.literal.value) {
case 'boolean':
return ['Boolean']
case 'string':
return ['String']
case 'number':
case 'bigint':
return ['Number']
}
if (node.literal.value instanceof RegExp) {
return ['RegExp']
}
}

return [`null`]
case 'TSTypeReference':
if (node.typeName.type === 'Identifier') {
const variable = findVariable(context.getScope(), node.typeName.name)
Expand Down
22 changes: 22 additions & 0 deletions tests/lib/rules/require-valid-default-prop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,28 @@ ruleTester.run('require-valid-default-prop', rule, {
parserOptions: { ecmaVersion: 6, sourceType: 'module' },
parser: require.resolve('@typescript-eslint/parser'),
errors: errorMessage('function')
},
{
filename: 'test.vue',
code: `<script setup lang="ts">
export interface SomePropInterface {
someProp?: false | string;
str?: 'foo' | 'bar';
num?: 1 | 2;
}

withDefaults(defineProps<SomePropInterface>(), {
someProp: false,
str: 'foo',
num: 1
});
</script>`,
parserOptions: {
ecmaVersion: 6,
sourceType: 'module',
parser: require.resolve('@typescript-eslint/parser')
},
parser: require.resolve('vue-eslint-parser')
}
],

Expand Down