Skip to content

fix(runtime-core): custom-element: ensure number casting of camelCase props. (fix: #5374) #5377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2022
Merged

fix(runtime-core): custom-element: ensure number casting of camelCase props. (fix: #5374) #5377

merged 1 commit into from
Oct 22, 2022

Conversation

@LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Feb 8, 2022

close: #5374

@netlify
Copy link

netlify bot commented Feb 8, 2022 •
edited
Loading

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: ba95eee

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/6202a0858514ab0007ac3061

😎 Browse the preview: https://deploy-preview-5377--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Feb 8, 2022 •
edited
Loading

❌ Deploy Preview for vuejs-coverage failed.

🔨 Explore the source changes: ba95eee

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/6202a0856995d2000875fd2b

@netlify
Copy link

netlify bot commented Feb 8, 2022 •
edited
Loading

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: ba95eee

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/6202a0859949100008022d8d

😎 Browse the preview: https://deploy-preview-5377--vue-sfc-playground.netlify.app/

@LinusBorg LinusBorg added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: custom elements labels Feb 8, 2022
@LinusBorg
Copy link
Member Author

LinusBorg commented Feb 8, 2022

No idea why that one netlify preview failed. the test that fails in it works fine in CI and locally.

@LinusBorg LinusBorg requested a review from antfu October 20, 2022 19:48
@LinusBorg LinusBorg merged commit b0b74a1 into main Oct 22, 2022
@LinusBorg LinusBorg deleted the linusborg/camelcase-props-casting-5374 branch October 22, 2022 09:20
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@LinusBorg
fix(runtime-core): custom-element: ensure number casting of camelCase…
feb1871 
… props. (fix: vuejs#5374) (vuejs#5377)
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
@LinusBorg @zhangzhonghe
fix(runtime-core): custom-element: ensure number casting of camelCase…
a3c1e6f 
… props. (fix: vuejs#5374) (vuejs#5377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@antfu antfu antfu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: custom elements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prop type conversion fails on Custom Element with camelCase prop name

3 participants

@LinusBorg @antfu