Skip to content

fix(keep-alive): should successfully set ref with async comp #5004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(keep-alive): should successfully set ref with async comp #5004

wants to merge 2 commits into from

Conversation

Bigfish8
Copy link
Contributor

fix #4999

edison1105
edison1105 reviewed Oct 29, 2024
View reviewed changes
packages/runtime-core/__tests__/components/KeepAlive.spec.ts
toggle.value = true
await nextTick()

expect(instanceRef.value).not.toBe(null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not enough to simply check that instanceRef.value is not null. We need to ensure that the methods exposed by AsyncComp can be called correctly to fully match the use case of #4999. I tested the reproduction of #4999 with this PR, and it did not pass.

@edison1105 edison1105 mentioned this pull request Oct 29, 2024
Merged
@yyx990803 yyx990803 closed this in 983eb50 Nov 15, 2024
abdullah-wn pushed a commit to Lazy-work/vue that referenced this pull request Jan 4, 2025
@edison1105 @abdullah-wn
fix(templateRef): set ref on cached async component which wrapped in …
7ec0db0 
…KeepAlive (vuejs#12290)

close vuejs#4999
close vuejs#5004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 left review comments

Assignees
No one assigned
Labels
scope: keep-alive
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

无法通过ref正确执行懒加载的动态子组件
2 participants
@Bigfish8 @edison1105