Skip to content

Conversation

@edison1105
Copy link
Member

@edison1105 edison1105 commented Apr 6, 2024

close #5148

@github-actions
Copy link

github-actions bot commented Apr 6, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.6 kB (+57 B) 34.4 kB (+24 B) 31.1 kB (+38 B)
vue.global.prod.js 148 kB (+57 B) 53.7 kB (+23 B) 47.9 kB (+57 B)

Usages

Name Size Gzip Brotli
createApp 50.8 kB (+61 B) 19.9 kB (+36 B) 18.1 kB (+25 B)
createSSRApp 54.1 kB (+61 B) 21.2 kB (+28 B) 19.3 kB (+25 B)
defineCustomElement 53.1 kB (+61 B) 20.6 kB (+33 B) 18.8 kB (+68 B)
overall 64.4 kB (+57 B) 24.9 kB (+28 B) 22.5 kB (-13 B)

@edison1105 edison1105 changed the title fix(runtime-core): suspense content inherit scopeId fix(runtime-core): ensure suspense content inherit scopeId Apr 7, 2024
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Apr 7, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure success
nuxt success success
pinia success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify failure failure
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Apr 14, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@ferferga
Copy link
Contributor

ferferga commented May 9, 2024

@edison1105 Sorry for pinging you again.

May we have this PR labeled as "ready to review" to attract a bit more of attention by potential reviewers now that we're starting with the v3.5.z cycle? The original issue has been open for 3 years and it's labeled as priority 4, so definitely this PR is worth it!

@edison1105 edison1105 added the ready for review This PR requires more reviews label May 9, 2024
@ferferga
Copy link
Contributor

@yyx990803 Sorry for the ping, but can we get a review on this to hopefully have this in before 3.5.0 stable? As stated above, Suspense has long-standing issues with Transition for years and this is a simple fix that will get it finally resolved.

@yyx990803 yyx990803 merged commit ac2a410 into vuejs:main Aug 19, 2024
@ferferga
Copy link
Contributor

ferferga commented Aug 19, 2024

@yyx990803 Thank you very much!! 🚀🚀🚀🚀
Really appreciated!

@edison1105 Thank you very much as well for your energy for doing fixes so quick!

ferferga added a commit to jellyfin/jellyfin-vue that referenced this pull request Aug 29, 2024
Vue 3.5 fixed the issue where Suspense didn't inherit correctly the scope id.

See vuejs/core/pull/10652
ferferga added a commit to jellyfin/jellyfin-vue that referenced this pull request Aug 29, 2024
Vue 3.5 fixed the issue where Suspense didn't inherit correctly the scope id.

See vuejs/core/pull/10652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review This PR requires more reviews scope: suspense

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suspended component + transition

4 participants