Skip to content

Typescript compilation error with latest apollo package #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2019
Merged

Typescript compilation error with latest apollo package #627

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31ee8ad
Typescript compilation error with latest apollo package
ihpannu May 24, 2019
0206572
Merge branch 'master' into patch-1
Akryum Jun 20, 2019
ce2dba7
fix: better optimisticResponse typing
Akryum Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/options.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export interface VueApolloQueryOptions<V, R> extends ExtendableVueApolloQueryOpt
export interface VueApolloMutationOptions<V, R> extends MutationOptions<R> {
mutation: DocumentNode;
variables?: VariableFn<V>;
optimisticResponse?: ((this: ApolloVueThisType<V>) => any) | Object;
optimisticResponse?: ((this: ApolloVueThisType<V>) => any) | any
Copy link

@airgram airgram Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is much better to use strong types:

optimisticResponse?: ((this: ApolloVueThisType<V>) => R) | R

}

export interface VueApolloSubscriptionOptions<V, R> extends SubscriptionOptions {
Expand Down