Skip to content

Enhancement #453 Reactive pollInterval. #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2019
Merged

Enhancement #453 Reactive pollInterval. #613

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66025c2
Enhancement Akryum#453 Reactive pollInterval.
joelmandell May 16, 2019
45ab7ba
Small change for pollInterval enhancement #453
joelmandell May 16, 2019
ea6af08
Remove unnecessary if-check in pollIntervalChanged
joelmandell May 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/smart-apollo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default class SmartApollo {
this.initialOptions = options
this.options = Object.assign({}, options)
this._skip = false
this._pollInterval = null
this._watchers = []
this._destroyed = false

Expand All @@ -29,6 +30,22 @@ export default class SmartApollo {
} else {
this._skip = true
}

if(typeof this.options.pollInterval === 'function') {
this._pollWatcher = this.vm.$watch(this.options.pollInterval.bind(this.vm),this.pollIntervalChanged.bind(this), {immediate:true})
}
}

pollIntervalChanged (value, oldValue) {
if (value !== oldValue) {
this.pollInterval = value

if(value == null) {
this.stopPolling()
} else {
this.startPolling(value)
}
}
}

skipChanged (value, oldValue) {
Expand All @@ -37,6 +54,14 @@ export default class SmartApollo {
}
}

get pollInterval() {
return this._pollInterval
}

set pollInterval(value) {
this._pollInterval = value
}

get skip () {
return this._skip
}
Expand Down