Add query key as additional parameter to result callback, #445 #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ps - the key parameter might be more intuitive as the first parameter, but added after data to leave it backwards compatible with existing code. |
Contributor
Author
|
result callback call from subscription also needs key parameter added (subsequent push) |
Contributor
Author
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the query key as an additional to the result callback function, to allow the callback function to identify which query the result is coming from. This is very useful to use allow manual SmartQuery instances to take action based on what type or client of query is incoming. This is particularly crucial when trying to use vue-apollo to connect to multiple backends with the same schema (#216).