Also allow to have Sensitive[String[1]] for rootdn #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only rootpw can be assigned as Sensitive, but in some cases one might want to keep the username (DN) out of the PuppetDB and the logs. In our case, we use a secret lookup function that automatically wraps the data into a Sensitive type, and we store the DN and password together.
|
A very basic spec test has been added. I am unsure if it is useful, maybe adding an acceptance test would be better? |
|
@bastelfreak I ping you here since you commented on my previous PR that I closed due to issues with my setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Currently only rootpw can be assigned as Sensitive, but in some cases one might want to keep the username (DN) out of the PuppetDB and the logs.
In our case, we use a secret lookup function that automatically wraps the data into a Sensitive type, and we store the DN and password together.
This Pull Request (PR) fixes the following issues
Not reported as an issue.