Skip to content

Conversation

@DarkLight1337
Copy link
Member

This PR fixes a bug introduced by #9424 that breaks speculative decoding usage. A special "draft" task is now reserved for models that are designed as draft models.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I don't really understand why we introduced "task"

@DarkLight1337
Copy link
Member Author

LGTM, although I don't really understand why we introduced "task"

As mentioned in #9424, some embedding models use the same architecture name as the corresponding text generation model, so we need to specify the task for vLLM to know which worker to initialize.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 19, 2024 04:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 19, 2024
@DarkLight1337 DarkLight1337 merged commit 263d8ee into main Oct 19, 2024
69 checks passed
@DarkLight1337 DarkLight1337 deleted the draft-task branch October 19, 2024 07:02
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants