Skip to content

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Oct 31, 2025

Special cases that needed handling:

  • Make nn.Parameter inheritable when it's mocked
  • Make registering a custom op a no-op (decorator and functional)

General improvements:

  • If vLLM asks for a package version, get it from requirements/test.txt
  • Some runtime imports need mocking too, handle those
  • Add if __name__ == "__main__" to make the script easier to test

@mergify
Copy link

mergify bot commented Oct 31, 2025

Documentation preview: https://vllm--27873.org.readthedocs.build/en/27873/

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Oct 31, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a robust mechanism for mocking imports during documentation generation, which significantly improves the developer experience by removing the need for heavy dependencies like PyTorch. The approach to handle runtime imports and special cases for nn.Parameter and custom ops is well-designed. I have identified a minor issue in how package versions are parsed from the requirements file, which could lead to incorrect version strings. My review includes a specific code suggestion to make this parsing more robust. Overall, this is a valuable improvement.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 31, 2025 15:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 31, 2025
@DarkLight1337 DarkLight1337 merged commit 799ce45 into vllm-project:main Nov 1, 2025
45 checks passed
@hmellor hmellor deleted the fully-mock-docs branch November 1, 2025 10:49
zhaozuy pushed a commit to zhaozuy/vllm that referenced this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants