-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[BUG] Make 'binary' default option for saving torch compile artifacts when using standalone_compile #27616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[BUG] Make 'binary' default option for saving torch compile artifacts when using standalone_compile #27616
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f05576a
make binary default option for saving compile cache
ahao-anyscale 5c6389c
remove print
ahao-anyscale cc5aa0b
updated compile docs
ahao-anyscale f6a6947
Update envs.py
ahao-anyscale 1839fa6
Update torch_compile.md
ahao-anyscale 159ef5e
Merge branch 'main' into binary-compile
ahao-anyscale 713b231
added save format to compilation config
ahao-anyscale 0dc88a4
Merge branch 'binary-compile' of https://github.com/ahao-anyscale/vll…
ahao-anyscale 0bff9fe
update docs
ahao-anyscale 7b0b272
docs
ahao-anyscale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want the binary option to be the default over the unpacked option?
@youkaichao I think you had strong opinions over this before, so would like to get your opinion.
We're deciding between having vLLM save compiled artifacts in "unpacked" mode or "binary" mode by default.
In "unpacked mode", you are able to put breakpoints into the inductor output code and look at it.
In "binary mode", you're not able to put breakpoints into the inductor output code or look at it. However, you gain the ability to launch vLLM processes at the same time to compile the same exact model without clobbering each other.
So I think the question is how much we value the ability to launch multiple vLLM processes performing compilation at the same time.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think by default its a bit less confusing to have binary option as default, since I assume most users will not be putting breakpoints in inductor. On the flip side, i think it is reasonable that people may be spawning multiple model replicas simultaneously, and will be very confused to see strange race condition errors with no warnings