[VLM][Refactor] Remove useless func get_input_positions in MRotaryEmbedding
#27088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MengqingCao <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a straightforward refactoring that removes the unused get_input_positions function from the MRotaryEmbedding class, along with its now-unnecessary import. Based on the provided context and the pull request description, this function was indeed dead code. The removal is a good cleanup that improves code maintainability. The change is correct and I have no further suggestions.
DarkLight1337
approved these changes
Oct 17, 2025
Member
DarkLight1337
left a comment
DarkLight1337
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…Embedding` (vllm-project#27088) Signed-off-by: MengqingCao <[email protected]>
albertoperdomo2
pushed a commit
to albertoperdomo2/vllm
that referenced
this pull request
Oct 23, 2025
…Embedding` (vllm-project#27088) Signed-off-by: MengqingCao <[email protected]> Signed-off-by: Alberto Perdomo <[email protected]>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…Embedding` (vllm-project#27088) Signed-off-by: MengqingCao <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…Embedding` (vllm-project#27088) Signed-off-by: MengqingCao <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…Embedding` (vllm-project#27088) Signed-off-by: MengqingCao <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…Embedding` (vllm-project#27088) Signed-off-by: MengqingCao <[email protected]> Signed-off-by: 0xrushi <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…Embedding` (vllm-project#27088) Signed-off-by: MengqingCao <[email protected]> Signed-off-by: 0xrushi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove useless func
get_input_positionsinMRotaryEmbedding. Since #24172, we dropedget_input_position_tensorsin vLLM, and there is no use ofget_input_positionsanymore. This pr removes the useless funcTest Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.