Skip to content

[Bugfix][Attention][DCP] Set reorder_batch_threshold back to 1 when using FlashMLA and enable DCP #27023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+13 −0
Closed

[Bugfix][Attention][DCP] Set reorder_batch_threshold back to 1 when using FlashMLA and enable DCP #27023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions vllm/v1/attention/backends/mla/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,19 @@ def __init__(
self.dcp_world_size = 1
self.dcp_rank = 0

if (
self.dcp_world_size > 1
and self.__class__.reorder_batch_threshold > 1
and self.__class__.__name__ != "FlashAttnMLAMetadataBuilder"
):
logger.warning_once(
"DCP is enabled but not FlashAttnMLA is used. "
"Set query_len_support back to SINGLE_ONLY "
"and reorder_batch_threshold back to 1."
)
self.__class__.query_len_support = QueryLenSupport.SINGLE_ONLY
self.__class__.reorder_batch_threshold = 1

# Don't try to access the runner on AMD
if self.aot_schedule:
self.page_size = self.kv_cache_spec.block_size
Expand Down