-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Feature][Responses API] Stream Function Call - harmony #24317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Responses API] Stream Function Call - harmony #24317
Conversation
|
Be careful with your commit! |
|
@QwertyJack Thanks~ |
8ee6c2f to
57c7e58
Compare
|
/cc @yeqcharlotte PTAL. |
|
This pull request has merge conflicts that must be resolved before it can be |
bd86ca9 to
cafaea7
Compare
|
/cc @yeqcharlotte @qandrew PTAL. |
yeqcharlotte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the change! function_call_parsing will be a heated path, let's pay more attention to perf :D
Hi @yeqcharlotte I've adopted a different approach for the implementation, and there are no performance issues now. Please take another look. |
Signed-off-by: chaunceyjiang <[email protected]>
yeqcharlotte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the change! it looks much better now. wonder did we get a chance to try this with any function call evals?
@qandrew - take a second look at the streaming component?
I've added a test case, |
Signed-off-by: chaunceyjiang <[email protected]>
qandrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments, otherwise LGTM. cc @yeqcharlotte
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
qandrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @yeqcharlotte
…#24317) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: Dhruvil Bhatt <[email protected]>
…#24317) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: bbartels <[email protected]>
…#24317) Signed-off-by: chaunceyjiang <[email protected]>
|
Hi, thank you for adding the function_call feature! 🙏 When making multiple tool calls, only the first tool call appears in the OutputItemDoneEvent. "response": { |
|
Hi, @goldanghenry-debug .
Yes. ref #24637. It seems that making the same request again will result in a second tool. |
|
OpenAI's documentation states that the However, this limitation can be bypassed by removing that token |
…#24317) Signed-off-by: chaunceyjiang <[email protected]>
…#24317) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
…#24317) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
…#24317) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: 0xrushi <[email protected]>
…#24317) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: 0xrushi <[email protected]>
…#24317) Signed-off-by: chaunceyjiang <[email protected]>
…#24317) Signed-off-by: chaunceyjiang <[email protected]>
Part of #23222
Refer to https://cookbook.openai.com/articles/openai-harmony#developer-message-format
Refer to https://platform.openai.com/docs/guides/function-calling?lang=python#streaming
Purpose
Stream Function Call - harmony
Test Plan
Test Result
Teat: