Skip to content

[Deprecation] Remove mean pooling default for Qwen2EmbeddingModel #18913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

[Deprecation] Remove mean pooling default for Qwen2EmbeddingModel #18913

merged 2 commits into from
May 30, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented May 29, 2025

Deprecated in #10769. We should now use the pooling model adapter as_embedding_model to construct the embedding model automatically, just like other models.

@DarkLight1337 DarkLight1337 requested a review from Isotr0py May 29, 2025 16:20
@DarkLight1337 DarkLight1337 requested a review from hmellor as a code owner May 29, 2025 16:20
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 29, 2025
@github-actions
Copy link

github-actions bot commented May 29, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label May 29, 2025
@DarkLight1337 DarkLight1337 changed the title [Deprecation] Remove custom MEAN pooling default for Qwen2EmbeddingModel [Deprecation] Remove mean pooling default for Qwen2EmbeddingModel May 29, 2025
@DarkLight1337
Fix
c107848 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 30, 2025 02:26
@DarkLight1337 DarkLight1337 merged commit 4f4a6b8 into vllm-project:main May 30, 2025
68 checks passed
@DarkLight1337 DarkLight1337 deleted the qwen2-embedding branch May 30, 2025 06:53
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@DarkLight1337 @amitm02
[Deprecation] Remove mean pooling default for Qwen2EmbeddingModel (v…
5ffccb7 
…llm-project#18913)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: amit <[email protected]>
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@DarkLight1337 @amitm02
[Deprecation] Remove mean pooling default for Qwen2EmbeddingModel (v…
5d7675e 
…llm-project#18913)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: amit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@Isotr0py Isotr0py Isotr0py approved these changes

@hmellor hmellor Awaiting requested review from hmellor

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DarkLight1337 @jeejeelee @Isotr0py