-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Update sequence.py to prevent LogitsProcessor objects from being deepcopied #16349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…copied Deepcopying sampling_params that include LogitsProcessor might lead to OOM. This has been an old issue here: vllm-project#3087 and the previous commit fixed this issue in vllm/engine/llm_engine.py https://github.com/vllm-project/vllm/pull/3099/files
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
houseroad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Fix the pre-commit, also is it a way to add a unittest to guard this?
|
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
|
This pull request has merge conflicts that must be resolved before it can be |
|
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
|
closing as obsolete |
Deepcopying sampling_params that include LogitsProcessor might lead to OOM. This has been an old issue here:
#3087
and the previous commit #3099 fixed this issue in vllm/engine/llm_engine.py
However it is re-occurring in vllm/sequence.py. This commit is trying to fix this again.