Skip to content

Conversation

@khluu
Copy link
Collaborator

@khluu khluu commented Apr 3, 2025

The directory has too many scripts. This is to move those scripts that run hardware CI into scripts/hardware_ci and other scripts into scripts/ to better organize the directory

p
Signed-off-by: kevin <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 3, 2025
@DarkLight1337
Copy link
Member

Do we have to sync the merge with another PR on our CI repo?

@khluu
Copy link
Collaborator Author

khluu commented Apr 3, 2025

Do we have to sync the merge with another PR on our CI repo?

Yes I need to sync merge it with vllm-project/ci-infra#83

p
Signed-off-by: kevin <[email protected]>
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simon-mo simon-mo merged commit 4dc52e1 into main Apr 4, 2025
20 of 23 checks passed
@simon-mo simon-mo deleted the khluu/reorganize_bk branch April 4, 2025 19:16
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants