-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[Bugfix] Fix use_cascade_attention handling for Alibi-based models on vllm/v1 #15211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
WoosukKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h-sugi Thanks for the PR! Left some minor comments.
Signed-off-by: h-sugi <[email protected]>
Signed-off-by: h-sugi <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]> Signed-off-by: h-sugi <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]> Signed-off-by: h-sugi <[email protected]>
Signed-off-by: h-sugi <[email protected]>
Signed-off-by: h-sugi <[email protected]>
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: h-sugi <[email protected]>
Signed-off-by: h-sugi <[email protected]>
|
@h-sugi Thanks for updating the PR! I will merge if the tests go well. |
… vllm/v1 (vllm-project#15211) Signed-off-by: h-sugi <[email protected]> Co-authored-by: Woosuk Kwon <[email protected]> Signed-off-by: xinyuxiao <[email protected]>
… vllm/v1 (vllm-project#15211) Signed-off-by: h-sugi <[email protected]> Co-authored-by: Woosuk Kwon <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
… vllm/v1 (vllm-project#15211) Signed-off-by: h-sugi <[email protected]> Co-authored-by: Woosuk Kwon <[email protected]>
… vllm/v1 (vllm-project#15211) Signed-off-by: h-sugi <[email protected]> Co-authored-by: Woosuk Kwon <[email protected]>
… vllm/v1 (vllm-project#15211) Signed-off-by: h-sugi <[email protected]> Co-authored-by: Woosuk Kwon <[email protected]> Signed-off-by: Mu Huai <[email protected]>
When using Alibi-based models like MPT, the following assertion error causes.
This is because that the determination logic for
use_cascadeingpu_model_runner.pyincorrectly uses a hard-codeduse_alibi=False. Therefore,cascade_attentionis wrongly enabled.This PR allows setting
use_alibibased on the alibi configuration specified in theconfig.jsonfor MPT models.