Skip to content

Conversation

@russellb
Copy link
Member

This restores this line of code back to the original implementation.
We've changed it multiple times trying to work around xgrammar's
handling of additional special tokens, but 0.1.16 should be good with
this original behavior.

The fix in particular that simplifies this for us is:

mlc-ai/xgrammar@70c959f

Signed-off-by: Russell Bryant [email protected]

This restores this line of code back to the original implementation.
We've changed it multiple times trying to work around xgrammar's
handling of additional special tokens, but 0.1.16 should be good with
this original behavior.

The fix in particular that simplifies this for us is:

mlc-ai/xgrammar@70c959f

Signed-off-by: Russell Bryant <[email protected]>
@russellb russellb requested a review from mgoin as a code owner March 16, 2025 20:38
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 16, 2025 20:39
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 16, 2025
@russellb
Copy link
Member Author

xgrammar API changes broke the V0 integration ... we can hold this in case I want to add more to it tomorrow to test something. @aarnphm is also trying to resolve this in #14868. We will probably end up merging that one.

@aarnphm aarnphm closed this Mar 17, 2025
auto-merge was automatically disabled March 17, 2025 01:36

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants