Skip to content

Conversation

@ywang96
Copy link
Member

@ywang96 ywang96 commented Mar 15, 2025

Change the default text-to-text example to use vllm backend (i.e, completions) so it's better aligned with the offline case.

Signed-off-by: Roger Wang <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@JenZhao JenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 15, 2025
@ywang96 ywang96 changed the title [Misc] Minor benchmark README update [Misc][Doc] Minor benchmark README update Mar 15, 2025
@jeejeelee jeejeelee merged commit 3453b96 into main Mar 16, 2025
27 checks passed
@jeejeelee jeejeelee deleted the updatereadme branch March 16, 2025 01:46
DefTruth pushed a commit to DefTruth/vllm that referenced this pull request Mar 17, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants