Skip to content

Conversation

@liangfu
Copy link
Contributor

@liangfu liangfu commented Mar 14, 2025

There are two changes:

  • change network from host to bridge
    • This is because we want to enable EnableDockerUserNamespaceRemap=true, which enables Docker user namespace remapping so docker runs as buildkite-agent. Otherwise, docker would raise Error response from daemon: cannot share the host's network namespace when user namespaces are enabled.
  • reduce device to single neuron device /dev/neuron0 for upto 2-core test suite, since each neuron-device may include 2 physical NeuronCores.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 14, 2025
@liangfu liangfu changed the title [Neuron] update docker run command [Neuron][CI] update docker run command Mar 14, 2025
@liangfu
Copy link
Contributor Author

liangfu commented Mar 14, 2025

cc @khluu @aws-satyajith

@khluu khluu enabled auto-merge (squash) March 14, 2025 22:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 14, 2025
@khluu khluu merged commit 9f37422 into vllm-project:main Mar 15, 2025
22 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants