-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Misc] Gemma3ForConditionalGeneration supports LoRA #14797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Can you merge from main to fix the CI? |
Done |
|
@WoosukKwon do you know whether this model is supposed to support LoRA already? |
|
@DarkLight1337 Oh I don't see any reason not. While I haven't tested myself, I think the model should be able to support it. |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Jee Jee Li <[email protected]>
3c08506 to
223fea2
Compare
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Richard Liu <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Mu Huai <[email protected]>
FIX #14789