Skip to content

Conversation

@jeejeelee
Copy link
Collaborator

FIX #14789

Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee requested a review from DarkLight1337 March 14, 2025 05:45
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

Can you merge from main to fix the CI?

@jeejeelee
Copy link
Collaborator Author

Can you merge from main to fix the CI?

Done

@DarkLight1337
Copy link
Member

@WoosukKwon do you know whether this model is supposed to support LoRA already?

@WoosukKwon
Copy link
Collaborator

@DarkLight1337 Oh I don't see any reason not. While I haven't tested myself, I think the model should be able to support it.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 14, 2025 06:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 14, 2025
@mergify
Copy link

mergify bot commented Mar 14, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jeejeelee.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 14, 2025
Signed-off-by: Jee Jee Li <[email protected]>
@mergify mergify bot removed the needs-rebase label Mar 14, 2025
@vllm-bot vllm-bot merged commit 989ecd2 into vllm-project:main Mar 14, 2025
5 of 8 checks passed
@jeejeelee jeejeelee deleted the gemma3-mm-lora branch March 14, 2025 08:22
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Clarification on LoRA Support for Gemma3ForConditionalGeneration

4 participants