Skip to content

[Misc] Clean up type annotation for SupportsMultiModal #14794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 14, 2025
Merged

[Misc] Clean up type annotation for SupportsMultiModal #14794

merged 5 commits into from
Mar 14, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Mar 14, 2025 •
edited
Loading

Add MultiModalEmbeddings type alias and use it for SupportsMultiModal interface.

@github-actions
Copy link

github-actions bot commented Mar 14, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 14, 2025
@DarkLight1337 DarkLight1337 requested a review from jeejeelee March 14, 2025 04:16
@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Mar 14, 2025 •
edited
Loading

Actually wait, let me update the other methods as well Done

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 14, 2025
@DarkLight1337 DarkLight1337 changed the title [Misc] Clean up type annotation for get_multimodal_embeddings [Misc] Clean up type annotation for SupportsMultiModal Mar 14, 2025
@DarkLight1337
Fix
ec0aad6 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 14, 2025 06:56
@DarkLight1337
Fix PP
fd3bb1f 
Signed-off-by: DarkLight1337 <[email protected]>
@vllm-bot vllm-bot merged commit 601bd32 into vllm-project:main Mar 14, 2025
3 of 6 checks passed
@DarkLight1337 DarkLight1337 deleted the mm-embeddings-interface branch March 14, 2025 08:00
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
@DarkLight1337 @richardsliu
[Misc] Clean up type annotation for SupportsMultiModal (vllm-projec…
4c47a67 
…t#14794)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
[Misc] Clean up type annotation for SupportsMultiModal (vllm-projec…
c9275e1 
…t#14794)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
[Misc] Clean up type annotation for SupportsMultiModal (vllm-projec…
7c1deb3 
…t#14794)

Signed-off-by: DarkLight1337 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Misc] Clean up type annotation for SupportsMultiModal (vllm-projec…
56f6412 
…t#14794)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96

@jeejeelee jeejeelee Awaiting requested review from jeejeelee

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DarkLight1337 @Isotr0py @vllm-bot