-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[V1] Delay all xgrammar usage until needed #14616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
NickLucche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on my side (TPU). I also like the fact that you're only initializing when structured output is enabled.
Thank you for the quick testing! |
|
This pull request has merge conflicts that must be resolved before it can be |
PR vllm-project#14575 delayed initialization of the grammar bitmask until it was needed to try to fix a problem encountered on TPU systems. Unfortunately, that change was not sufficient. We need to delay usage of ALL xgrammar APIs, not just the grammar initialization. This change implements that. More initialization is now deferred until the first time a structured output request is received. Signed-off-by: Russell Bryant <[email protected]>
ae99fc9 to
dd05b0f
Compare
|
rebased to resolve conflicts after #14622 went in |
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Mu Huai <[email protected]>
PR #14575 delayed initialization of the grammar bitmask until it was
needed to try to fix a problem encountered on TPU systems.
Unfortunately, that change was not sufficient.
We need to delay usage of ALL xgrammar APIs, not just the grammar
initialization. This change implements that. More initialization is now
deferred until the first time a structured output request is received.
Signed-off-by: Russell Bryant [email protected]