Skip to content

Conversation

@ywang96
Copy link
Member

@ywang96 ywang96 commented Mar 10, 2025

FIXES #14528
FIXES #13629

Tested with (both V0 and V1)
pytest -v -s tests/models/decoder_only/vision_language/test_models.py::test_video_models -k qwen2_vl
and
pytest -v -s tests/models/decoder_only/vision_language/test_models.py::test_video_models -k qwen2_5_vl with transformers=4.49.0

Signed-off-by: Roger Wang <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Roger Wang <[email protected]>
ywang96 added 3 commits March 10, 2025 09:48
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passes on my end as well, should be good to go!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 10, 2025 14:20
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 10, 2025
@DarkLight1337 DarkLight1337 merged commit dea985a into vllm-project:main Mar 10, 2025
50 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

2 participants