Skip to content

[Bugfix] Add file lock for ModelScope download #14060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 1, 2025
Merged

[Bugfix] Add file lock for ModelScope download #14060

merged 5 commits into from
Mar 1, 2025

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Feb 28, 2025

FIX #13962

@jeejeelee
Done
e9cfa14 
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee
Add comment
74d5941 
Signed-off-by: Jee Jee Li <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 28, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

DarkLight1337
DarkLight1337 reviewed Feb 28, 2025
View reviewed changes
@jeejeelee
Done
4aa8652 
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee force-pushed the modelscope-download-lock branch from 830b11f to 4aa8652 Compare March 1, 2025 02:04
@jeejeelee jeejeelee requested a review from DarkLight1337 March 1, 2025 02:05
@jeejeelee
Make mypy happy
81d72c2 
Signed-off-by: Jee Jee Li <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 1, 2025 04:52
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 1, 2025
@DarkLight1337 DarkLight1337 merged commit 6a84164 into vllm-project:main Mar 1, 2025
47 of 49 checks passed
@jeejeelee jeejeelee deleted the modelscope-download-lock branch March 1, 2025 17:19
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@jeejeelee @Akshat-Tripathi
[Bugfix] Add file lock for ModelScope download (vllm-project#14060)
1a94642 
Signed-off-by: Jee Jee Li <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@jeejeelee @lulmer
[Bugfix] Add file lock for ModelScope download (vllm-project#14060)
0d6d18b 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@jeejeelee @shreyankg
[Bugfix] Add file lock for ModelScope download (vllm-project#14060)
7e6fdb8 
Signed-off-by: Jee Jee Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Download model many times when use VLLM_USE_MODELSCOPE and --tensor-parallel-size > 1

2 participants

@jeejeelee @DarkLight1337