-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Misc][Platform] Move use allgather to platform #14010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Mengqing Cao <[email protected]>
f8f848e to
30bfa86
Compare
|
@youkaichao could you help review this? thx! |
youkaichao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
|
CI failed due to network issue |
Signed-off-by: Mengqing Cao <[email protected]>
Signed-off-by: Mengqing Cao <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Mengqing Cao <[email protected]>
Mainly changes
use_all_gatherto platform so that the oot devices could override it instead of modifying in vLLMsampling_metadata.seq_groupsbefore applying logits processor, as when using all-gather, the logits is not none, butsampling_metadata.seq_groupsis none, so_apply_logits_processorswill raise an unexpected error. We add this check to avoid step into_apply_logits_processorswhen using all-gather