Skip to content

DeepSeek V2/V3/R1 only place lm_head on last pp rank #13833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

DeepSeek V2/V3/R1 only place lm_head on last pp rank #13833

merged 1 commit into from
Feb 26, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Feb 25, 2025

Balances memory usage across pipeline ranks by reducing the amount used on all ranks that are not the last rank.

@github-actions
Copy link

github-actions bot commented Feb 25, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor moved this from Backlog to In progress in DeepSeek V3/R1 Feb 25, 2025
@hmellor hmellor mentioned this pull request Feb 25, 2025
Closed
1 task
@github-project-automation github-project-automation bot moved this from In progress to In review in DeepSeek V3/R1 Feb 25, 2025
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 25, 2025
@mgoin mgoin enabled auto-merge (squash) February 25, 2025 19:08
@mgoin mgoin merged commit 2467978 into vllm-project:main Feb 26, 2025
57 of 60 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in DeepSeek V3/R1 Feb 26, 2025
@hmellor hmellor deleted the fix-deepseek-lm-head-pp branch February 26, 2025 07:07
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@hmellor @Akshat-Tripathi
DeepSeek V2/V3/R1 only place lm_head on last pp rank (vllm-project#…
1f90308 
…13833)

Signed-off-by: Harry Mellor <[email protected]>
@hmellor hmellor mentioned this pull request Apr 2, 2025
Closed
1 task
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@hmellor @lulmer
DeepSeek V2/V3/R1 only place lm_head on last pp rank (vllm-project#…
ed96cf6 
…13833)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@hmellor @shreyankg
DeepSeek V2/V3/R1 only place lm_head on last pp rank (vllm-project#…
5e5fc5f 
…13833)

Signed-off-by: Harry Mellor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

DeepSeek V3/R1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hmellor @mgoin