Skip to content

Conversation

@russellb
Copy link
Member

While doing some testing with xgrammar, I ran into an supported
attribute for a string type. I checked the code and found some things
we weren't checking for.

Details can be found by searching for warnUnsupportedKeywords in
this file:

https://github.com/mlc-ai/xgrammar/blob/main/cpp/json_schema_converter.cc

Signed-off-by: Russell Bryant [email protected]

While doing some testing with xgrammar, I ran into an supported
attribute for a string type. I checked the code and found some things
we weren't checking for.

Details can be found by searching for `warnUnsupportedKeywords` in
this file:

https://github.com/mlc-ai/xgrammar/blob/main/cpp/json_schema_converter.cc

Signed-off-by: Russell Bryant <[email protected]>
@russellb russellb requested a review from mgoin as a code owner February 24, 2025 19:34
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the xgrammar team will have this support soon, but we should def get this in for now

@russellb probably we should want to add a note to to remove it once it is supported upstream

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 24, 2025
@mgoin
Copy link
Member

mgoin commented Feb 24, 2025

Would be good to add a json schema test case for this so we know we won't regress in the future

@russellb
Copy link
Member Author

Would be good to add a json schema test case for this so we know we won't regress in the future

I'll look at this for V1 CI coverage at least

@mgoin mgoin enabled auto-merge (squash) February 24, 2025 21:48
@mgoin mgoin merged commit aab3927 into vllm-project:main Feb 25, 2025
59 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed structured-output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants