-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Core] xgrammar: Expand list of unsupported jsonschema keywords #13783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] xgrammar: Expand list of unsupported jsonschema keywords #13783
Conversation
While doing some testing with xgrammar, I ran into an supported attribute for a string type. I checked the code and found some things we weren't checking for. Details can be found by searching for `warnUnsupportedKeywords` in this file: https://github.com/mlc-ai/xgrammar/blob/main/cpp/json_schema_converter.cc Signed-off-by: Russell Bryant <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
aarnphm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the xgrammar team will have this support soon, but we should def get this in for now
@russellb probably we should want to add a note to to remove it once it is supported upstream
|
Would be good to add a json schema test case for this so we know we won't regress in the future |
I'll look at this for V1 CI coverage at least |
…-project#13783) Signed-off-by: Russell Bryant <[email protected]>
…-project#13783) Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…-project#13783) Signed-off-by: Russell Bryant <[email protected]>
While doing some testing with xgrammar, I ran into an supported
attribute for a string type. I checked the code and found some things
we weren't checking for.
Details can be found by searching for
warnUnsupportedKeywordsinthis file:
https://github.com/mlc-ai/xgrammar/blob/main/cpp/json_schema_converter.cc
Signed-off-by: Russell Bryant [email protected]