-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[Misc] set single whitespace between log sentences #13771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: cjackal <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Gosh I didn't mean to buster call every vllm maintainers, it's just a tiny code quality PR. |
|
Seems like this PR will be green after #13772 , pre-commit passed on my local repo. |
russellb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
the pre-commit failure will be fixed by #13772 |
tlrmchlsmth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: cjackal <[email protected]>
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Signed-off-by: cjackal <[email protected]>
Signed-off-by: cjackal <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: cjackal <[email protected]>
Set single whitespace between log / error sentences.
I just grepped
logger.*\(andError(and filtered by counting whitespaces between lines, so the list in this commit is not inclusive.