Skip to content

Conversation

@cjackal
Copy link
Contributor

@cjackal cjackal commented Feb 24, 2025

Set single whitespace between log / error sentences.

I just grepped logger.*\( and Error( and filtered by counting whitespaces between lines, so the list in this commit is not inclusive.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@cjackal
Copy link
Contributor Author

cjackal commented Feb 24, 2025

Gosh I didn't mean to buster call every vllm maintainers, it's just a tiny code quality PR.

@cjackal
Copy link
Contributor Author

cjackal commented Feb 24, 2025

Seems like this PR will be green after #13772 , pre-commit passed on my local repo.

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@russellb
Copy link
Member

the pre-commit failure will be fixed by #13772

Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: cjackal <[email protected]>
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 24, 2025
@mgoin mgoin enabled auto-merge (squash) February 24, 2025 17:42
@youkaichao youkaichao disabled auto-merge February 25, 2025 02:26
@youkaichao youkaichao merged commit 51010a1 into vllm-project:main Feb 25, 2025
76 of 80 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants