Skip to content

[CI/Build] Fix V1 LoRA failure #13767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2025
Merged

[CI/Build] Fix V1 LoRA failure #13767

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5c6a82
Done
jeejeelee Feb 24, 2025
81af024
Fix OOM
jeejeelee Feb 25, 2025
cd03663
Fix V1 LoRA OOM
jeejeelee Feb 25, 2025
75c9156
Merge branch 'vllm-project:main' into fix-v1-lora
jeejeelee Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/lora/test_gemma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ def v1(run_with_both_engines_lora):
pass


# The V1 lora test for this model requires more than 24GB.
@pytest.mark.skip_v1
@pytest.mark.xfail(current_platform.is_rocm(),
reason="There can be output mismatch on ROCm")
def test_gemma_lora(gemma_lora_files):
Expand Down