Skip to content

Conversation

@ywang96
Copy link
Member

@ywang96 ywang96 commented Feb 21, 2025

#13533 added a new mm_processor_kwarg field to ChatCompletionRequest but it should be added to all chat-related protocols with messages: List[ChatCompletionMessageParam]. This PR fixes this issue.

Signed-off-by: Roger Wang <[email protected]>
@ywang96 ywang96 changed the title [Bugfix] Add mm_processor_kwargs to EmbeddingChatRequest with [Bugfix] Add mm_processor_kwargs to EmbeddingChatRequest Feb 21, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Feb 21, 2025
Signed-off-by: Roger Wang <[email protected]>
@ywang96 ywang96 changed the title [Bugfix] Add mm_processor_kwargs to EmbeddingChatRequest [Bugfix] Add mm_processor_kwargs to chat-related protocols Feb 21, 2025
@ywang96 ywang96 marked this pull request as ready for review February 21, 2025 03:29
@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 21, 2025
@DarkLight1337
Copy link
Member

I wonder how that passed mypy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants