Skip to content

[BugFix] Don't scan entire cache dir when loading model #13302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2025
+8 −10
Merged

[BugFix] Don't scan entire cache dir when loading model #13302

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
552b3a5
[BugFix] Don't scan entire cache dir when loading model
njhill Feb 14, 2025
b98d6a6
only log download time if longer than half a second
njhill Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions vllm/model_executor/model_loader/weight_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
import huggingface_hub.constants
import numpy as np
import torch
from huggingface_hub import (HfFileSystem, hf_hub_download, scan_cache_dir,
snapshot_download)
from huggingface_hub import HfFileSystem, hf_hub_download, snapshot_download
from safetensors.torch import load_file, safe_open, save_file
from tqdm.auto import tqdm

Expand Down Expand Up @@ -239,7 +238,8 @@ def download_weights_from_hf(
Returns:
str: The path to the downloaded model weights.
"""
if not huggingface_hub.constants.HF_HUB_OFFLINE:
local_only = huggingface_hub.constants.HF_HUB_OFFLINE
if not local_only:
# Before we download we look at that is available:
fs = HfFileSystem()
file_list = fs.ls(model_name_or_path, detail=False, revision=revision)
Expand All @@ -255,7 +255,6 @@ def download_weights_from_hf(
# Use file lock to prevent multiple processes from
# downloading the same model weights at the same time.
with get_lock(model_name_or_path, cache_dir):
start_size = scan_cache_dir().size_on_disk
start_time = time.perf_counter()
hf_folder = snapshot_download(
model_name_or_path,
Expand All @@ -264,12 +263,11 @@ def download_weights_from_hf(
cache_dir=cache_dir,
tqdm_class=DisabledTqdm,
revision=revision,
local_files_only=huggingface_hub.constants.HF_HUB_OFFLINE,
local_files_only=local_only,
)
end_time = time.perf_counter()
end_size = scan_cache_dir().size_on_disk
if end_size != start_size:
logger.info("Time took to download weights for %s: %.6f seconds",
if not local_only:
logger.info("Time spent downloading weights for %s: %.6f seconds",
model_name_or_path, end_time - start_time)
Copy link
Member

@mgoin mgoin Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This seems like a frivolous log if we want to remove. Maybe you could skip it if the duration is < 1 second

Copy link
Member Author

@njhill njhill Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with half a second :)

What I think would be nice for later would be to somehow consolidate the various startup timings in a single log line that gives kind of a breakdown of the total time (download, weight load, compilation, ...)

Copy link

@MikeSpreitzer MikeSpreitzer Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone trying to understand latency and the things causing it, I find it definitely not frivolous to specifically identify the latency due to downloading.

return hf_folder

Expand Down