Skip to content

Conversation

@chenjunyi-dev
Copy link

@chenjunyi-dev chenjunyi-dev commented Nov 13, 2025

What this PR does / why we need it?

This PR mainly does the following things:

  1. add mlapo test script
  2. support cachemode int8_nzcache with bf16 in mlapo
  3. mlapo fit different hidden state dim

Does this PR introduce any user-facing change?

How was this patch tested?

python tests/ops/test_mla_preprocess.py

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several significant improvements. It refactors the mlapo pre-processing logic to support dynamic hidden state dimensions, removing hardcoded values and making the implementation more flexible. It also adds support for int8_nzcache with bfloat16 data type. A key contribution of this PR is the addition of a comprehensive test script for mlapo, which replaces a minimal test with a full test suite. This new suite includes multiple parameter combinations, different cache modes, and two separate "golden" implementations for robust verification. The code changes are clean and the testing is thorough. Overall, this is a high-quality contribution that enhances functionality, flexibility, and test coverage.

@chenjunyi-dev chenjunyi-dev changed the title add mlapo test script [Bugfix] Add mlapo test script Nov 13, 2025
@chenjunyi-dev chenjunyi-dev changed the title [Bugfix] Add mlapo test script [bugfix] add mlapo test script Nov 13, 2025
@MengqingCao MengqingCao added ready read for review ready-for-test start test by label for PR labels Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants