Skip to content

Conversation

@vitalybaev
Copy link
Contributor

@vitalybaev vitalybaev commented Nov 3, 2025

Description

As mentioned in #8910, actual implementation of toContainElement() matcher of accepts Locator for element, but TypeScript doesn't allow this, as well as it's not stated in the docs

Resolves #8910

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a921b19
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69092cdc931d7b000825ca28
😎 Deploy Preview https://deploy-preview-8927--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vitalybaev vitalybaev marked this pull request as draft November 3, 2025 22:49
@vitalybaev vitalybaev force-pushed the fix/to-contain-element-locator-type branch from a921b19 to 082ba31 Compare November 3, 2025 22:55
@vitalybaev vitalybaev marked this pull request as ready for review November 4, 2025 08:34
@sheremet-va sheremet-va merged commit 35a27d4 into vitest-dev:main Nov 4, 2025
10 of 14 checks passed
@sheremet-va
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

toContainElement types don't allow locators

2 participants